From 4d8a29074813edf1e387c84b0fd6fe2136ff5333 Mon Sep 17 00:00:00 2001
From: Tycho Bokdam <tycho@palmtreecoding.com>
Date: Sun, 28 Jun 2020 20:20:56 +0200
Subject: [PATCH] refactor: Cleanup in generateChangelog

---
 src/helpers/generateChangelog.js | 67 +++++++++++++++++++++-----------
 1 file changed, 45 insertions(+), 22 deletions(-)

diff --git a/src/helpers/generateChangelog.js b/src/helpers/generateChangelog.js
index 5a66972..ca2f250 100644
--- a/src/helpers/generateChangelog.js
+++ b/src/helpers/generateChangelog.js
@@ -1,17 +1,39 @@
 const fs = require('fs')
 const conventionalChangelog = require('conventional-changelog')
 
-module.exports.generateStringChangelog = (tagPrefix, preset, jsonPackage, releaseCount) => new Promise((resolve, reject) => {
-  const changelogStream = conventionalChangelog({
-      preset,
-      releaseCount: parseInt(releaseCount, 10),
-      tagPrefix,
-    },
-    {
-      version: jsonPackage.version,
-      currentTag: `${tagPrefix}${jsonPackage.version}`,
-    },
-  )
+/**
+ * Generates a changelog stream with the given arguments
+ *
+ * @param tagPrefix
+ * @param preset
+ * @param version
+ * @param releaseCount
+ * @returns {*}
+ */
+const getChangelogStream = (tagPrefix, preset, version, releaseCount) => conventionalChangelog({
+    preset,
+    releaseCount: parseInt(releaseCount, 10),
+    tagPrefix,
+  },
+  {
+    version,
+    currentTag: `${tagPrefix}${version}`,
+  },
+)
+
+module.exports = getChangelogStream
+
+/**
+ * Generates a string changelog
+ *
+ * @param tagPrefix
+ * @param preset
+ * @param version
+ * @param releaseCount
+ * @returns {Promise<string>}
+ */
+module.exports.generateStringChangelog = (tagPrefix, preset, version, releaseCount) => new Promise((resolve, reject) => {
+  const changelogStream = getChangelogStream(tagPrefix, preset, version, releaseCount)
 
   let changelog = ''
 
@@ -22,17 +44,18 @@ module.exports.generateStringChangelog = (tagPrefix, preset, jsonPackage, releas
     .on('end', () => resolve(changelog))
 })
 
-module.exports.generateFileChangelog = (tagPrefix, preset, jsonPackage, fileName, releaseCount) => new Promise((resolve) => {
-  const changelogStream = conventionalChangelog({
-      preset,
-      releaseCount: parseInt(releaseCount, 10),
-      tagPrefix,
-    },
-    {
-      version: jsonPackage.version,
-      currentTag: `${tagPrefix}${jsonPackage.version}`,
-    },
-  )
+/**
+ * Generates a file changelog
+ *
+ * @param tagPrefix
+ * @param preset
+ * @param version
+ * @param fileName
+ * @param releaseCount
+ * @returns {Promise<>}
+ */
+module.exports.generateFileChangelog = (tagPrefix, preset, version, fileName, releaseCount) => new Promise((resolve) => {
+  const changelogStream = getChangelogStream(tagPrefix, preset, version, releaseCount)
 
   changelogStream
     .pipe(fs.createWriteStream(fileName))